Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions to use flow-typed #1067

Closed
wants to merge 2 commits into from
Closed

Add instructions to use flow-typed #1067

wants to merge 2 commits into from

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Nov 20, 2016

No description provided.

@rricard
Copy link
Contributor Author

rricard commented Nov 20, 2016

Followup from #72.

Requires flow-typed/flow-typed#467 to be merged first.

@rricard
Copy link
Contributor Author

rricard commented Nov 22, 2016 •
edited

Alright! flow-typed/flow-typed#467 is merged so what is written here is true!

However, the CI failed on yarn for no clear reason (I just changed the README)

denkristoffer
denkristoffer reviewed Dec 7, 2016
View reviewed changes
Copy link
Contributor

@denkristoffer denkristoffer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, indicate to flow where to get those annotations by adding the following [libs] section to your .flowconfig:

Is this instruction necessary when flow checks flow-typed/ by default?

@rricard
Copy link
Contributor Author

rricard commented Dec 7, 2016

@sachse I'm now concentrating on #1152 that will make this PR unnecessary.

@rricard
Copy link
Contributor Author

rricard commented Dec 13, 2016

Closing in favor of #1152 that is almost there!

@rricard rricard closed this Dec 13, 2016
@rricard rricard deleted the flow-typed branch December 13, 2016 16:04
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denkristoffer denkristoffer denkristoffer left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rricard @denkristoffer @facebook-github-bot