Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for OSX users about watchman and jest #1080

Merged
merged 3 commits into from
Nov 23, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,14 @@ The watcher includes an interactive command-line interface with the ability to r

![Jest watch mode](http://facebook.github.io/jest/img/blog/15-watch.gif)

>**A note for Mac OSX users**

>If you start `npm test` and the execution hangs there might be a problem with your watchman installation as discovered in #713 and #1767.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make watchman and issues links.


> To solve the issues first make sure you run the latest verision: `brew install watchman` (4.7.0).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be "version".
Let's not hardcode specific version but say "make sure you run at least watchman 4.7.0 or newer".

Then execute `launchctl unload -F ~/Library/LaunchAgents/com.github.facebook.watchman.plist`. After these steps the issues should be resolved.


### Version Control Integration

By default, when you run `npm test`, Jest will only run the tests related to files changed since the last commit. This is an optimization designed to make your tests runs fast regardless of how many tests you have. However it assumes that you don’t often commit the code that doesn’t pass the tests.
Expand Down