Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PWA docs to point at the cra-template-pwa package #10805

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

slieschke
Copy link
Contributor

The links in the Progressive Web App docs page refer to some files which used to live inside cra-template package but now exist in the cra-template-pacakge in the cra-template/pwa repo. I've updated the template links to point to the new location, as well as some minor edits to account for serviceWorker.js being renamed to serviceWorkerRegistration.js.

@facebook-github-bot
Copy link

Hi @slieschke!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 4.1 milestone Apr 12, 2021
@ianschmitz
Copy link
Contributor

This is great. Thanks @slieschke!

@ianschmitz ianschmitz merged commit 4d3bbe0 into facebook:master Apr 12, 2021
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants