-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WP5] Webpack5 update #10961
[WP5] Webpack5 update #10961
Conversation
This reverts commit 3968923.
* upstream/master: Update IMAGE_INLINE_SIZE_LIMIT docs (#10631) Publish Update CHANGELOG Prepare 4.0.3 release update immer to 8.0.1 to address vulnerability (#10412) Upgrade eslint-webpack-plugin to fix opt-out flag (#10590) Bump webpack-dev-server 3.11.0 -> 3.11.1 (#10312) tests: update test case to match the description (#10384) Publish Prepare 4.0.2 release Add opt-out for eslint-webpack-plugin (#10170) Add support for new BUILD_PATH advanced configuration variable (#8986) appTsConfig immutability handling by immer (#10027) Fix CI tests (#10217) docs: add missing override options for Jest config (#9473)
This reverts commit 580ed5d.
References: * [hook rename](TypeStrong/fork-ts-checker-webpack-plugin#490) * [include/exclude](TypeStrong/fork-ts-checker-webpack-plugin#450) and [issue options](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#issues-options) * [release notes 5.0.0](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/releases/tag/v5.0.0)
Add css-minimizer-webpack-plugin@1.1.5 Remove optimize-css-assets-webpack-plugin and postcss-safe-parser References: * https://webpack.js.org/plugins/css-minimizer-webpack-plugin/
supporting incremental typescript builds
review feedback from @kumarlachhani
This just fixes a shell snippet in the readme file for this plugin
Replace the Github home link with a link to the repo's main page or a link to the source (https://github.com/CodeByZach/pace/blob/master/pace.js)
Bump immer minor version to fix `Prototype Pollution` Security issue.
.href is prefixed with http://localhost etc.
@@ -789,18 +795,6 @@ module.exports = function (webpackEnv) { | |||
}, | |||
}), | |||
].filter(Boolean), | |||
// Some libraries import Node modules but don't use them in the browser. | |||
// Tell webpack to provide empty mocks for them so importing them works. | |||
node: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change - not sure if we are good by doing that in a minor version bump? (imho we should not confuse new developers by depending on node js builtin shims on the front-end - npm is confusing enough as is)
reference: comment by @slorber #9994 (comment)
packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/JsonInclusion.js
Outdated
Show resolved
Hide resolved
accordingly to review by @xiaokekeT
This reverts commit 8fdc63b.
Thank you, it's work, I'll publish temporary package for testing on my own project |
@andriijas awesome that webpack 5 support was merged! Is this planned to land in 4.1 or 4.2? And thanks to @raix for getting this in! |
@karlhorky primary planned to land in some kind of prerelease to gather feedback and test results from real projects and detect edge cases. Appreciate your eagerness to elevate your stack with webpack 5 but some further patience is needed :) Also big applause to @raix for his continuous energy to work and make sure this is moving forward! 🙌 |
If you need help with anything from webpack side, we're here 🙌🏾 |
Thanks @evenstensberg only issue outstanding is multiple events from the compilatiln hook causing odd "ui" refresh in CLI - I haven't looked further into it, build works - (also had an issue with split/runtime chunks when enabling federated modules - for now reverted the commit but there's likely a config change needed) |
Webpack 5 update
Includes the work listed in #9994
Replace #10656 and targeting the wp5 branch
Additional changes:
Known issues:
Things I wanted to do but left out:
Credit include @andriijas, @sebinsua and @jasonwilliams (let me know if I missed out on any)