Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-hot-loader #110

Closed
wants to merge 1 commit into from
Closed

Add react-hot-loader #110

wants to merge 1 commit into from

Conversation

manrueda
Copy link

Add react-hot-loader to this great project!

@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Jul 22, 2016
@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Hi, thanks for PR!
I would be comfortable including it only after both HMR infrastructure and RHL itself are more stable.

@zikaari
Copy link
Contributor

zikaari commented Jul 20, 2017

Maybe we should have an experimental branch/release similar to how chrome has experimental flags, because having something like that is a good way to have massive community involved in usage and development*, and thus amp up contributions (bug reports and PR's)

* of create-react-app and its core deps (RHL etc.)

@stevemao
Copy link

stevemao commented Oct 13, 2018

Hi @gaearon , is React-Hot-Loader stable enough to be added here now?

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants