Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disabling clearing of terminal console #1109

Closed
wants to merge 1 commit into from

Conversation

a-morales
Copy link

Following the guide for integrating with a node backend, I found it a bit inconvenient having the start script clearing the console every time a file was saved when running everything through foreman.

This just adds the option to pass in a --verbose(not sure if this is the right flag name) option to the start script that won't clear the console. I've read the contributing guideline, and maybe this should be an option that is enabled by default whenever proxy is defined in package.json.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@gaearon
Copy link
Contributor

gaearon commented Nov 28, 2016

Is this related to #1032? Does #1032 already solve this?

@a-morales
Copy link
Author

@gaearon This is related to #1032, and I just gave this a try on the master branch and it works. I'll close the PR.

@a-morales a-morales closed this Nov 28, 2016
@gaearon
Copy link
Contributor

gaearon commented Nov 28, 2016

Great! We’ll try to get it out within a week or two.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants