Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (Docs) Updates for the Storybook docs #11315

Merged

Conversation

jonniebigodes
Copy link
Contributor

With this small pull request, the Storybook documentation is updated to include a more recent video/gif, and also some of the links were updated as well to redirect to their proper places.

What was done:

  • Updated the location of the gif to Storybook's own repo.
  • Fixed the links currently used to their respective place

The change to the way the gif was being added is intentional, and hope it's fine with all of you. The intention behind this is to avoid having to rely on an external provider and subsequent pull requests. If by any chance the Storybook UI changes, said gif will be updated and with that automatically propagate here.

Feel free to provide feedback

@facebook-github-bot
Copy link

Hi @jonniebigodes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
@jonniebigodes
Copy link
Contributor Author

Was going through my notifications and saw that this pull request was marked as stale. Can any of the maintainers check this and let me know of any feedback. Thanks in advance.

@stale stale bot removed the stale label Feb 1, 2022
@matrush matrush merged commit 706aaa1 into facebook:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants