Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workbox-webpack-plugin from version 6.1.5 to 6.2.0 #11317

Closed
wants to merge 2 commits into from
Closed

Update workbox-webpack-plugin from version 6.1.5 to 6.2.0 #11317

wants to merge 2 commits into from

Conversation

eliyamelamed1
Copy link

there were some updates on workbox-webpack-plugin for webpack 5 and module . This PR upgrades the dependency to its last version.

Currently react-scripts is using workbox-webpack-plugin=6.1.5 , this seems to cause to cause some problems and those problems were fixed in the last version of the plugin. With this PR we aim to upgrade the dependency to the latest version to 6.2.0 and resolve those issues.

#11293

@facebook-github-bot
Copy link

Hi @eliyamelamed1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@raix
Copy link
Contributor

raix commented Aug 20, 2021

Thanks @eliyamelamed1 - issue should be solved, main is now at 6.2.4 - closing

@raix raix closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants