Custom Lint Rule no-css-modules
#114
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
casesandberg
force-pushed
the
custom-lint-rule
branch
from
d64b3b3
to
dfac79c
Compare
|
The eslint command on the e2e script is failing, will check it out when I get home. |
| create: function (context) { | ||
| return { | ||
| ImportDeclaration: function(node) { | ||
| if (node) { |
There was a problem hiding this comment.
I wouldn't think this check is necessary right?
There was a problem hiding this comment.
Its guarded in one of the eslint rules with ImportDeclaration, happy to remove it if you dont think its necessary
casesandberg
force-pushed
the
custom-lint-rule
branch
from
dfac79c
to
0e344fe
Compare
|
Hi, we’d still like to merge this, but I don’t think it ever passed the end-to-end test. |
|
Closing as there hasn’t been a response, and it doesn’t seem like more people tripped on this. |
Closes #98. @gaearon