Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jsx-no-undef rule an error #1159

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Make jsx-no-undef rule an error #1159

merged 1 commit into from
Dec 5, 2016

Conversation

existentialism
Copy link
Contributor

Fixes #1158

@gaearon gaearon added this to the 0.8.2 milestone Dec 5, 2016
@gaearon gaearon merged commit 15f65a0 into facebook:master Dec 5, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Thank you!

@existentialism existentialism deleted the issue1158 branch December 5, 2016 20:00
mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
@mofelee
Merge branch 'master' into sparta-webapp
f8c88af 
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
@gaearon gaearon mentioned this pull request Dec 7, 2016
Merged
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@existentialism @alexdriaguine
Make jsx-no-undef rule an error (facebook#1159)
704ac03
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@existentialism @randycoulman
Make jsx-no-undef rule an error (facebook#1159)
baf9a2c
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@existentialism @gaearon @facebook-github-bot