-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to svgr 6 #11780
base: main
Are you sure you want to change the base?
Upgrade to svgr 6 #11780
Conversation
packages/react-scripts/package.json
Outdated
@@ -77,6 +76,7 @@ | |||
"workbox-webpack-plugin": "^6.4.1" | |||
}, | |||
"devDependencies": { | |||
"@svgr/webpack": "^6.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would still be a dependency of react-scripts
, as we want it to install when users install react-scripts
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Put it there by inertia.
Nice! Looks like this needs a rebase on |
Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0 This release bumped svgo internally which has a lot of fixes and less dependencies.
9631d46
to
f46435b
Compare
@iansu We are waiting on this pull request to fix nth check vulnerability. Can you please help us with ETA on this one.? |
It has been two months |
There are two PRs with update to newer version: |
Any news? |
did it solved ?? |
Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0
This release bumped svgo internally which has a lot of fixes and less
dependencies.