Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: browser selection via env variable #11878

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: browser selection via env variable #11878

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed61e6b
fix: browser selection via env variable
FloydJohn Jan 3, 2022
75660ca
chore: remove unused params on open invocation
FloydJohn May 11, 2022
bf17dda
Merge branch 'facebook:main' into fix-browser-env
FloydJohn Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react-dev-utils/openBrowser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ function startBrowserProcess(browser, url, args) {
try {
var options = {
app: { name: browser, arguments: args },
wait: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete the wait property?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I noticed the default is set to false, as described here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

url: true,
};
open(url, options).catch(() => {}); // Prevent `unhandledRejection` error.
return true;
Expand Down