Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: package.json: postinstall #158

Closed
wants to merge 1 commit into from

Conversation

sotayamashita
Copy link

I added npm-scripts, post-install to run AFTER the package is installed.

ref:

I added npm-scripts, post-install to run AFTER the package is installed.

ref:

* https://docs.npmjs.com/misc/scripts
@ghost ghost added the CLA Signed label Jul 24, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 24, 2016

What does this solve? I'm not sure I understand the intention.

@sotayamashita
Copy link
Author

@gaearon When developer contribute this project, I think it help them start developing. For example, if you there is not postinstall:

git clone ~ 
npm i
npm run build
npm start

However, if there is postinstall,

git clone ~
npm i
npm start

@ghost ghost added the CLA Signed label Jul 24, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 24, 2016

You don't need to run build before start. They are completely independent.

@gaearon gaearon closed this Jul 24, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 24, 2016

Closing since this doesn’t appear to be necessary.

nicosommi pushed a commit to nicosommi/create-react-app that referenced this pull request Mar 17, 2018
* feat(react-scripts/prod): use new uglifyJsPlugin for ES6 support

this closes facebook#21, facebook#158, facebook#248

* feat(react-scripts/prod): execute uglify plugin parallel + enable caching
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants