Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing things for people with the username cwd #1696

Merged
merged 2 commits into from
Mar 3, 2017
Merged

fixing things for people with the username cwd #1696

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bdc428
fixing things for people with the username `cwd`
chrisdrackett Mar 2, 2017
9b41c63
combine awk into a single command and add escaping
chrisdrackett Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dev-utils/getProcessForPort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function getProcessCommand(processId, processDirectory) {
}

function getDirectoryOfProcessById(processId) {
return execSync('lsof -p '+ processId + ' | grep cwd | awk \'{print $9}\'', execOptions).trim();
return execSync('lsof -p '+ processId + ' | awk '$4=="cwd"' | awk \'{print $9}\'', execOptions).trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single quotes in awk '$4=="cwd"' need to be escaped. Currently it terminates the string, causing JS parsing to fail for this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an awk expert, but looks like we could also combine the two awk commands: instead of piping to a separate command, we would just do awk '$4 == "cwd" { print $9 }'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and done!

}

function getProcessForPort(port) {
Expand Down