Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ignoreRestSiblings in no-unused-vars #1705

Merged
merged 8 commits into from
Mar 5, 2017
Merged

Add support for ignoreRestSiblings in no-unused-vars #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f3ed07
updating eslint to 3.16.1
chrisdrackett Mar 3, 2017
c172599
add support for ignoreRestSiblings in eslint
chrisdrackett Mar 3, 2017
ab92788
updating eslint to 3.16.1 in `react-scripts`
chrisdrackett Mar 3, 2017
059b6e7
updating eslint
chrisdrackett Mar 3, 2017
6c5a1c8
missing `^`
chrisdrackett Mar 3, 2017
3270b5d
missing ^
chrisdrackett Mar 3, 2017
a639490
pinning main eslint and updating readme
chrisdrackett Mar 3, 2017
4e9f4e3
Pin ESLint version
gaearon Mar 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"babel-eslint": "7.1.0",
"eslint": "3.8.1",
"eslint": "3.16.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also update this number in a few more places (search for it).

"eslint-config-react-app": "0.5.1",
"eslint-plugin-flowtype": "2.21.0",
"eslint-plugin-import": "2.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-react-app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If you want to use this ESLint configuration in a project not built with Create
First, install this package, ESLint and the necessary plugins.

```sh
npm install --save-dev eslint-config-react-app babel-eslint@7.0.0 eslint@3.8.1 eslint-plugin-flowtype@2.21.0 eslint-plugin-import@2.0.1 eslint-plugin-jsx-a11y@2.2.3 eslint-plugin-react@6.4.1
npm install --save-dev eslint-config-react-app babel-eslint@7.0.0 eslint@3.16.1 eslint-plugin-flowtype@2.21.0 eslint-plugin-import@2.0.1 eslint-plugin-jsx-a11y@2.2.3 eslint-plugin-react@6.4.1
```

Then create a file named `.eslintrc` with following contents in the root folder of your project:
Expand Down
3 changes: 2 additions & 1 deletion packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ module.exports = {
'no-unused-vars': ['warn', {
vars: 'local',
varsIgnorePattern: '^_',
args: 'none'
args: 'none',
ignoreRestSiblings: true,
}],
'no-use-before-define': ['warn', 'nofunc'],
'no-useless-computed-key': 'warn',
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"peerDependencies": {
"babel-eslint": "^7.0.0",
"eslint": "^3.8.1",
"eslint": "^3.16.1",
"eslint-plugin-flowtype": "^2.21.0",
"eslint-plugin-import": "^2.0.1",
"eslint-plugin-jsx-a11y": "^2.2.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"css-loader": "0.26.1",
"detect-port": "1.0.1",
"dotenv": "2.0.0",
"eslint": "3.8.1",
"eslint": "3.16.1",
"eslint-config-react-app": "^0.5.2",
"eslint-loader": "1.6.3",
"eslint-plugin-flowtype": "2.21.0",
Expand Down