Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly extract package name for installing tgz of scoped packages #1706

Merged
merged 8 commits into from
Mar 5, 2017
Merged

Properly extract package name for installing tgz of scoped packages #1706

merged 8 commits into from
Mar 5, 2017

Commits on Mar 5, 2017

  1. Properly extract package name

    @Timer @gaearon
    Timer authored and gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    37f975a View commit details
    Browse the repository at this point in the history

  2. Download package if need be ...

    @Timer @gaearon
    Timer authored and gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    290174a View commit details
    Browse the repository at this point in the history

  3. Oops

    @Timer @gaearon
    Timer authored and gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    dac3209 View commit details
    Browse the repository at this point in the history

  4. Add e2e test based on facebook#1537, but without specific filename

    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    454f908 View commit details
    Browse the repository at this point in the history

  5. Pass packageName through promises 

    A little bit more verbose but explicit and doesn't rely on shared mutable state.
    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    b78b49e View commit details
    Browse the repository at this point in the history

  6. Fix up directory name in test

    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    5d64ee4 View commit details
    Browse the repository at this point in the history

  7. Tweak failure message

    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    22f6945 View commit details
    Browse the repository at this point in the history

  8. Fix lint

    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    07c57de View commit details
    Browse the repository at this point in the history