Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ejecting from a scoped fork #1727

Merged
merged 3 commits into from
Mar 5, 2017
Merged

Fix ejecting from a scoped fork #1727

merged 3 commits into from
Mar 5, 2017

Commits on Mar 5, 2017

  1. Fix ejecting for a scoped react-scripts fork 

    We shouldn't hardcode react-scripts because fork name might differ.
We also shouldn't rely on it being an immediate child because scoped packages are a level deeper.
    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    e91218f View commit details
    Browse the repository at this point in the history

  2. Clarify that own* properties only exist before ejecting

    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    991714f View commit details
    Browse the repository at this point in the history

  3. Read script names from own bin instead of guessing 

    This fixes ejecting from a fork that uses a different bin script name.
    @gaearon
    gaearon committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    55fccd8 View commit details
    Browse the repository at this point in the history