Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'guard-for-in' lint rule #1773

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Remove 'guard-for-in' lint rule #1773

merged 1 commit into from
Mar 9, 2017

Commits on Mar 9, 2017

  1. Remove 'guard-for-in' lint rule 

    Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?
    @sophiebits
    sophiebits authored Mar 9, 2017
    Configuration menu
    Copy the full SHA
    3bea9d0 View commit details
    Browse the repository at this point in the history