Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update now instructions to support html5 history #1805

Closed
wants to merge 2 commits into from

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Mar 12, 2017

Passing the --single flag to ensure HTML5 history api support (for things like react router).

screenshot 2017-03-12 11 38 45

Passing the `--single` flag ensure html5 history api support.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Copy link

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@@ -1520,7 +1520,7 @@ When you build the project, Create React App will place the `public` folder cont
3. Add this line to `scripts` in `package.json`:

```
"now-start": "serve build/",
"now-start": "serve --single build/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use serve -s build for consistency with what we now suggest in CLI?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Mar 12, 2017

Do we need that trailing slash?

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Seems like this is obsolete with #2372.
I asked for confirmation in #2372 (comment).

@Timer
Copy link
Contributor

Timer commented Aug 2, 2017

I'll close this since it was replaced with #2372; thank you for your contribution @jaredpalmer!

@Timer Timer closed this Aug 2, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants