-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about duplicate dependencies #1862
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Since this is just a warning, I don't think we have to consider it breaking. /cc @gaearon |
I have two issues with this pull request, maybe someone can help me out. I noticed that warnings are not being displayed when building. The solution would be to display any warnings from The second issue is that the tests for kitchensink are failing since
After some digging, it appears that in the Any suggestions? |
You can bump |
Created new PR to the 0.9.x branch #1866 . Closing this PR. |
@Timer can you add tags and milestone to the other PR please? |
Add
duplicate-package-checker-webpack-plugin
as proposed here: #1844.