Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css modules #2341

Closed
wants to merge 2 commits into from
Closed

Add css modules #2341

wants to merge 2 commits into from

Conversation

abdulsattar
Copy link

This is a copy of #2285. We correct the css modules test for webpack.

@@ -204,8 +222,9 @@ module.exports = {
// "style" loader turns CSS into JS modules that inject <style> tags.
// In production, we use a plugin to extract that CSS to a file, but
// in development "style" loader enables hot editing of CSS.
// By default we support CSS Modules with the extension .modules.css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not .module.css? It makes more sense, isn't it?

@abdulsattar
Copy link
Author

Closing this because #2285 got everything working.

@abdulsattar abdulsattar deleted the add-css-modules branch May 24, 2017 05:06
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants