Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable comparisons feature in uglify compression in production #2379

Merged
merged 4 commits into from
May 27, 2017
Merged

Disable comparisons feature in uglify compression in production #2379

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cc4fef
Disable a micro-option in uglify that appears to be buggy
davidascher May 27, 2017
d49ba54
wrong plugin
davidascher May 27, 2017
73f311e
Add a comment
gaearon May 27, 2017
789f5bf
Merge branch 'master' into master
gaearon May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ module.exports = {
new webpack.optimize.UglifyJsPlugin({
compress: {
warnings: false,
comparisons: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a similar comment to the one below? We need to know when to re-enable it and have links.

// This feature has been reported as buggy a few times, such as:
// https://github.com/mishoo/UglifyJS2/issues/1964
// We'll wait with enabling it by default until it is more solid.
Expand Down