-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow importing package.json #2468
Merged
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6727da4
Allow importing package.json
iamdoron d22a9df
Remove package.json import from App.js template
iamdoron 9ef9fcb
fix importing package.json
iamdoron d382a94
Rename variable to reflect path is relative to root
iamdoron 18ee2fc
Check for both package & package.json in ModuleScopePlugin
iamdoron be60e23
Use regex to check relative path to package.json
iamdoron c288eca
Strictly enforce package.json extension on scope plugin
iamdoron 3a27a6c
Merge branch 'master' of https://github.com/facebookincubator/create-…
iamdoron ee51957
Add allowedPaths to ModuleScopePlugin ctor and use it to allow app pa…
iamdoron 077366e
Remove package.json import from App.js template
iamdoron f42dba0
Add package.json to react-scripts/template, show package version and …
iamdoron c223f86
Remove import package.json from template
iamdoron 7ac9883
Remove template/package.json and its references in code
iamdoron fab0f91
Update ModuleScopePlugin.js
Timer daf59f4
Update README.md
Timer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timer I changed it to regex, I added '?' in
(.json)?
to make it optional. that way you canrequire("../package")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should always include the extension no matter what.