Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect check if CI variable is set to true #2501

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Fix incorrect check if CI variable is set to true #2501

merged 2 commits into from
Jun 19, 2017

Commits on Jun 8, 2017

  1. Fix incorrect check if CI variable is set to true 

    Originally build would fail on warnings with any value of CI environment variable. Now it will correctly check if it's true.

Discussed here: #2453
    @varnav
    varnav committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    462e5d3 View commit details
    Browse the repository at this point in the history

  2. Check for "not false" instead of "not true" 

    After discussion we decided that this will be closer to current functionality and not break anything.
    @varnav
    varnav committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    3f5a625 View commit details
    Browse the repository at this point in the history