Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/webpack3 #2574

Merged
merged 20 commits into from
Jul 25, 2017
Merged

Feature/webpack3 #2574

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f1d8295
Add source-map-loader to support source maps of dependencies
ericvicenti May 25, 2017
1d15562
bump to WP3
Jun 20, 2017
49a2bfc
merge with latest develop
Jun 20, 2017
e26110b
Merge branch 'feature/webpack3' into develop
Jun 20, 2017
a5ea7ba
add ModuleConcatenationPlugin
Jun 22, 2017
deede11
revert source-map-loader
Jun 22, 2017
6aad3a2
bump to 3.1 and update dev-server
Jul 7, 2017
280d2d7
rebase to master
Jul 7, 2017
c6e68fa
rebase again
Jul 7, 2017
c9b82af
bump webpack
Jul 7, 2017
8230e8b
remove ModuleConcatenationPlugin, downgraded react packages, bump etwp
Jul 8, 2017
2c50764
Merge branch 'master' into feature/webpack3
themre Jul 8, 2017
e0bce04
ETWP rc1 only for testing
Jul 8, 2017
a9350e8
bump ETWP and webpack 3
Jul 13, 2017
8ba7654
Merge branch 'master' into feature/webpack3
themre Jul 21, 2017
95f8c5c
bump WP3
Jul 21, 2017
8d3e41f
revert to 3.2.0
Jul 21, 2017
caa126d
bump sw-precache-webpack-plugin
Jul 22, 2017
651cd15
bump back to 3.3.0
Jul 22, 2017
f6b6935
bump dev-server and manifest
Jul 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ module.exports = {
// Makes some environment variables available to the JS code, for example:
// if (process.env.NODE_ENV === 'development') { ... }. See `./env.js`.
new webpack.DefinePlugin(env.stringified),
new webpack.optimize.ModuleConcatenationPlugin(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't include this yet. It is too experimental.

// This is necessary to emit hot updates (currently CSS only):
new webpack.HotModuleReplacementPlugin(),
// Watcher doesn't work well if you mistype casing in a path so we use
Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ module.exports = {
},
sourceMap: true,
}),
new webpack.optimize.ModuleConcatenationPlugin(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

// Note: this won't work without ExtractTextPlugin.extract(..) in `loaders`.
new ExtractTextPlugin({
filename: cssFilename,
Expand Down
14 changes: 7 additions & 7 deletions packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@
"postcss-flexbugs-fixes": "3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we need to bump ExtractTextPlugin?

"postcss-loader": "2.0.5",
"promise": "7.1.1",
"react-dev-utils": "^3.0.0",
"react-error-overlay": "^1.0.7",
"style-loader": "0.17.0",
"sw-precache-webpack-plugin": "0.9.1",
"url-loader": "0.5.8",
"webpack": "2.6.1",
"webpack-dev-server": "2.4.5",
"react-dev-utils": "^3.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our own module. Please don't bump it now. It is bumped during the release.

"react-error-overlay": "^1.0.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

"style-loader": "0.18.2",
"sw-precache-webpack-plugin": "0.11.3",
"url-loader": "0.5.9",
"webpack": "3.1.0",
"webpack-dev-server": "2.5.1",
"webpack-manifest-plugin": "1.1.0",
"whatwg-fetch": "2.0.3"
},
Expand Down