Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Babel for react-dev-utils #2755

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ build
my-app*
packages/react-scripts/template
packages/react-scripts/fixtures
packages/react-dev-utils/*.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline here. Is it intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2017-08-23 at 8 51 37 pm 1
have it here, I think GitHub truncate it?

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"create-react-app": "node tasks/cra.js",
"e2e": "tasks/e2e-simple.sh",
"e2e:docker": "tasks/local-test.sh",
"postinstall": "node bootstrap.js && cd packages/react-error-overlay/ && npm run build:prod",
"postinstall": "node bootstrap.js && cd packages/react-dev-utils/ && npm run build:prod && cd ../react-error-overlay/ && npm run build:prod",
"publish": "tasks/release.sh",
"start": "node packages/react-scripts/scripts/start.js",
"screencast": "svg-term --cast hItN7sl5yfCPTHxvFg5glhhfp --out screencast.svg --window",
Expand Down
3 changes: 3 additions & 0 deletions packages/react-dev-utils/.babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": ["react-app"]
}
1 change: 1 addition & 0 deletions packages/react-dev-utils/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/*.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline here. Is it intended? [2]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2017-08-23 at 8 54 10 pm
same as above

15 changes: 12 additions & 3 deletions packages/react-dev-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@
"description": "Webpack utilities used by Create React App",
"repository": "facebookincubator/create-react-app",
"license": "MIT",
"scripts": {
"test": "jest",
"prepublish": "npm run build:prod",
"babel": "rimraf *.js && babel src/ -d ./",
"build": "cross-env NODE_ENV=development npm run babel",
"watch": "cross-env NODE_ENV=development npm run babel -- -w",
"build:prod": "cross-env NODE_ENV=production npm run babel"
},
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
Expand Down Expand Up @@ -56,9 +64,10 @@
"text-table": "0.2.0"
},
"devDependencies": {
"babel-cli": "6.24.1",
"babel-preset-react-app": "3.0.2",
"cross-env": "5.0.5",
"rimraf": "^2.6.1",
"jest": "20.0.4"
},
"scripts": {
"test": "jest"
}
}