-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2797 : Improve untracked files message during eject #2838
2797 : Improve untracked files message during eject #2838
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
doesn't look like my changes broke the builds, but I cannot rerun them to verify. |
Hi! We just merged #3416 to improve how files are displayed, but would still appreciate your adjusted wording. If possible, I'd like it to be a bit more terse and leave current wording. How about we just add another line after the instructions at the end? Modify "This will make it hard for you to resolve any unintended consequences eject may have on your changes" to be-post instruction, like "Doing this will make it easy" etc. |
Sure, will update it... |
Thanks! Sorry for letting this slip through the cracks. |
No Problem! it happens :-) |
Hmm, I'm not super fond of any of this wording. Let's revisit it sometime in the future. Thanks for the time you put into this! |
This attempts to improve the message shown to user when ejecting on a git repo having untracked changes ( Issue: #2797 )
Proposed message
Message break down:
I did not list the files (as was done previously) as that may lead users to more confusion (why is CRA having problem with this file etc.), instead tell the users how they can find it.
Testing:
Screenshot attached: