Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-config npm install command #3072

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Conversation

jdcrensh
Copy link
Contributor

@jdcrensh jdcrensh commented Sep 6, 2017

The npm install script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.

The `npm install` script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.
@Timer
Copy link
Contributor

Timer commented Sep 6, 2017

Great catch!
Thank you so much.

@Timer Timer merged commit b17fa41 into facebook:master Sep 6, 2017
@jdcrensh jdcrensh deleted the patch-1 branch September 6, 2017 21:44
matart15 pushed a commit to matart15/create-react-app that referenced this pull request Sep 13, 2017
…react-app

* 'master' of https://github.com/facebookincubator/create-react-app:
  Resolved issue facebook#2971 (facebook#2989)
  Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107)
  Updated react-error-overlay to latest Flow (0.54.0) (facebook#3065)
  Auto-detect running editor on Linux for error overlay (facebook#3077)
  Clean target directory before compiling overlay (facebook#3102)
  Rerun prettier and pin version (facebook#3058)
  Reload the page when an error has occurred (facebook#3098)
  run npm 5.4.0 in CI (facebook#3026)
  Unmapper Windows compatibility (facebook#3079)
  Update eslint-config npm install command (facebook#3072)
  Set travis config to use 'precise' ci environment
  Publish
  Changelog for 1.0.13
  Add missing slash
  Make error overlay filename configurable (facebook#3028)
  provide empty mock for child_process so importing libraries with it works (facebook#3033)
  Rename Overlay to ErrorOvelay (facebook#3051)
  Strip hash from chunk file name (facebook#3049)
  Fix error overlay 'Object.assign' issue in IE by including polyfills before webpack client (facebook#3046)
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
The `npm install` script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
The `npm install` script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
The `npm install` script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants