Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add click-to-open support for build errors #3100

Merged
merged 9 commits into from
Oct 6, 2017
Merged

Add click-to-open support for build errors #3100

merged 9 commits into from
Oct 6, 2017

Commits on Oct 4, 2017

  1. Implement click-to-open for babel syntax errors in build error overlay

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    830c4e9 View commit details
    Browse the repository at this point in the history

  2. Add click-to-open support for lint errors and refactor parser

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    51236e9 View commit details
    Browse the repository at this point in the history

  3. Reactor code to reuse open-in-editor functionality in both build and … 

    …runtime error overlays
    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    de8e9b6 View commit details
    Browse the repository at this point in the history

  4. Fix some eslint warnings

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    5c0cccf View commit details
    Browse the repository at this point in the history

  5. Add a comment about keeping middleware and dev client in sync

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    88cd256 View commit details
    Browse the repository at this point in the history

  6. Remove es6 features from webpack dev client

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    64ef981 View commit details
    Browse the repository at this point in the history

  7. Make open-in-editor functionality to work with new iframe script

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    8d36cd9 View commit details
    Browse the repository at this point in the history

  8. Rename openInEditor to editorHandler 

     -  Remove indirection of openInEditorListener
 -  Check editorHandler for null before styling error clickable
    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    a0b3566 View commit details
    Browse the repository at this point in the history

  9. Fix flow errors

    @tharakawj
    tharakawj committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    ae18e55 View commit details
    Browse the repository at this point in the history