Redisable require.ensure() #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The accompanying eslint rule will need re-enabled too. 😄 |
|
Oh, right! One moment |
everdimension
force-pushed
the
redisable-require-ensure
branch
from
adaeb5b
to
315d962
Compare
|
Done! |
|
Sigh, sorry for requesting a review by accident @gaearon; this is the 2nd time I've done this. 😛 |
|
Thanks @everdimension! This will probably be on the back burner until 2.0.0. 😄 |
|
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 315d962) has been released on npm for testing purposes. npm i react-scripts-canary@1.0.14-315d962.0
# or
yarn add react-scripts-canary@1.0.14-315d962.0
# or
create-react-app --scripts-version=react-scripts-canary@1.0.14-315d962.0 folder/Thanks for your contribution! |
|
We might as well try this again. Better now that there's the import hints. |
gaearon
pushed a commit
that referenced
this pull request
Jan 10, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
Timer
pushed a commit
that referenced
this pull request
Jan 11, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 13, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 13, 2018
Timer
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this (#2176) issue has been closed, seems like this code was meant to be brought back.