Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Template Fixes #318

Merged
merged 2 commits into from
Aug 1, 2016
Merged

README Template Fixes #318

merged 2 commits into from
Aug 1, 2016

Conversation

hnordt
Copy link
Contributor

@hnordt hnordt commented Aug 1, 2016

No description provided.

@ghost ghost added the CLA Signed label Aug 1, 2016
@@ -233,7 +233,7 @@ Please be advised that this is also a custom feature of Webpack.

### Install React Bootstrap

React Bootstrap is not a dependency for using React however it is a popular alternative for integrating Bootstrap with React apps. It can be integrated with Create React App workflow using following three steps.
React Bootstrap is not a dependency for using React however it is a popular alternative for integrating Bootstrap with React apps. It can be integrated with Create React App workflow following three steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the author meant “using the following three steps”. But I agree it’s a bit clumsy.
Let’s reword to completely avoid passive?

You don’t have to use React Bootstrap together with React but it is a popular library for integrating Bootstrap with React apps. If you need it, you can integrate it with Create React App by following these steps:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; file updated.

@gaearon gaearon merged commit 6e1887f into facebook:master Aug 1, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 1, 2016

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants