Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable yarn install on eject for non-windows machines #3347

Closed
wants to merge 16 commits into from

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 29, 2017

Issue three was fixed in July (yarnpkg/yarn#3811). 😄

Closes #2627.

Non-Windows users will no longer need to manually run Yarn after ejecting.

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do what I suggested in the other PR and instead just run npm and yarn to remove old dep and add new ones. I remember we didn't do it before because it was too slow with npm 2. Should be fine with modern versions. Also ejecting doesn't have to be super fast, it should be reliable.

@Timer
Copy link
Contributor Author

Timer commented Nov 5, 2017

Sigh, "The batch file cannot be found." strikes again -- @xjlim do you know why this happens when Yarn is called via spawnSync?

https://ci.appveyor.com/project/gaearon/create-react-app-a3khu/build/1.0.1784/job/j63f1m0x7qv8baqt#L1548

@Timer Timer dismissed gaearon’s stale review November 5, 2017 16:17

Code has been updated

@gaearon
Copy link
Contributor

gaearon commented Nov 5, 2017

@gaearon
Copy link
Contributor

gaearon commented Jan 16, 2018

Fixed in #3806

@gaearon gaearon closed this Jan 16, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should ejecting change lockfile?
3 participants