-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable yarn install on eject for non-windows machines #3347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do what I suggested in the other PR and instead just run npm
and yarn
to remove old dep and add new ones. I remember we didn't do it before because it was too slow with npm 2. Should be fine with modern versions. Also ejecting doesn't have to be super fast, it should be reliable.
7825048
to
780bed1
Compare
Sigh, "The batch file cannot be found." strikes again -- @xjlim do you know why this happens when Yarn is called via |
Maybe need to add "cmd" like we do here? |
574dd1c
to
397b151
Compare
9a1ba30
to
9e7833c
Compare
Fixed in #3806 |
Issue three was fixed in July (yarnpkg/yarn#3811). 😄
Closes #2627.
Non-Windows users will no longer need to manually run Yarn after ejecting.