-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added initial POC for flow support #350
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
cc @thejameskyle, I would love if someone from the Flow team could look at this and offer what can be improved in this implementation (webpack “loader” is like a browserify transform). Here’s a popular TypeScript loader for comparison. |
I would love some pointers from Flow team. The current implementation in not optimal and also will hide errors if the |
I tried it out last couple of days, seems to work fine 👍 |
@gabriel-laet You are right. I hacked that in a night for POC. If you check the |
@torifat 👍 I will try to find some time and help on the performance issue |
Hey @torifat thanks for taking the time to do this, I'd like to chat about it some more. Does Twitter DMs work for you? |
@thejameskyle yes, it will do. |
Hmm. I'm not sure we should even use a webpack loader. Using the flow-ide package, I get errors inline in my editor as I code. Then we can just run |
@ccorcos Editor integrations are great for sure but there’s a much wider reach when you build something in, as opposed to making it available via IDE plugins. |
True... What additional features would you like to see that the typescript loader offers that this flow loader doesn't? |
I'm closing because unfortunately it doesn't appear like Flow team is interested in Create React App or Webpack integration, and there's no sense in keeping this hang here forever. |
@gaearon that isn't true, I asked you to merge this over a month ago. |
Please reopen this. In my opinion, it's ready to be merged, if you disagree let me know. |
@thejameskyle need to update the implementation. |
Sorry, I didn't see that message from you or maybe misunderstood. |
POC for issue #324
Instead of
vim .flowconfig
, you can dowget https://gist.githubusercontent.com/torifat/756443d1bab62abda5f87c3ca2c90dc8/raw/ab2464634e3b0cd873d0ff302a83a5097964276f/.flowconfig
too.Sample
App.js
:Sample Output:
![screenshot 2016-08-04 07 48 00](https://cloud.githubusercontent.com/assets/208544/17387697/d00e8b1e-5a17-11e6-9889-d99d141f3073.png)