-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Babel 7 #3522
Merged
Merged
Switch to Babel 7 #3522
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
7a07a1a
Update dependencies in react-scripts
7cbeb83
Add first pass of working dependencies for babel-preset-react-app and…
b0ba884
Bump more dependency versions
5cb193c
Adjust more versions and edit fix options
ae2b569
Restore functionality of old preset
222a905
Disable Uglify in iframe webpack
f9391f7
Apply prettier
fbaacf4
Re-enable cache in dev and clean deps
0cdf4f9
Lock packages and move babel/core to dep in preset
dc15217
Bump babel-jest
60a42ae
Re-enable uglify
Timer 911debc
Nest forceAllTransforms correctly in webpack config
8003d54
Install babel-core bridge for jest
c180b49
Add jest-cli and babel-core bridge to make tests in react-error-overl…
eff7257
Re-enable transform-dynamic-import
Timer ca7516d
Add dynamic import syntax support back
Timer 482abf2
Use new babel in kitchensink
Timer 539e46a
Transform modules in test
Timer 60a5f57
Revert "Transform modules in test"
Timer 67ca211
Attempt fix for ejected tests
Timer 60ab887
try this
Timer 95dbd6f
Add regenerator back
dea535e
Bump babel deps to beta.34
1466478
Remove bad files
Timer ab26521
Use default when requiring babel transform plugin
fb6480d
Bump deps
Timer f95e5a9
Try the fix?
gaearon 7f29d27
Oopsie
gaearon 44d93ab
Merge branch 'next' into 2.0-beta
gaearon b81c25f
Remove some weird things
gaearon 174ddf5
Run Babel on react-error-overlay tests
gaearon 9f504c2
Try fixing kitchensink
gaearon 4ade5c3
Use new API for codeFrame
gaearon 9537092
Add missing (?) babelrc
gaearon a29c74d
Maybe this helps?
gaearon effe64a
Maybe fix mocha
gaearon 0d5043d
I shouldn't have deleted this :facepalm:
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
packages/react-scripts/fixtures/kitchensink/.template.dependencies.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this looks very fragile, why did we add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, okay. #3522 (comment)
sigh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be pretty reliable -- it resolves
chalk
from the context of@babel/code-frame
(so we find the correct module which needs compiling).Same for
ansi-styles
andchalk
.Alternatively, we can just always compile those modules.