Add mjs and jsx filename extensions to file-loader exclude pattern #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kingdutch can you confirm this fixes #3520? |
|
@Timer This is the slightly more explicit version of my suggestion in the issue : ) Applied it locally and it fixes the issue 👍 |
|
We like explicitness for beginners who eject. 😄 |
kellyrmilligan
added a commit
to kellyrmilligan/create-react-app
that referenced
this pull request
Dec 15, 2017
* master: Updates comment to reflect codebase (facebook#3576) Add mjs and jsx filename extensions to file-loader exclude pattern (facebook#3537)
|
@Timer or @gaearon could you release this change please?
...and we can't use external libs which file extension is actual: loader: require.resolve('file-loader'),
exclude: [/\.js$/, /\.html$/, /\.json$/],expected: loader: require.resolve('file-loader'),
exclude: [/\.(js|jsx|mjs)$/, /\.html$/, /\.json$/],Thanks! |
|
Even without ejecting, importing a |
|
It'll be out in the next release. |
|
This is out in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3520
See issue for steps to reproduce/test.