Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reading environment variables from .env file in babel-preset-react-app #3544

Closed
wants to merge 2 commits into from

Conversation

GnsP
Copy link

@GnsP GnsP commented Dec 4, 2017

In reference to Issue #2377 [closed].

babel-preset-react-app requires that NODE_ENV or BABEL_ENV be set to "development" | "test" | "production". Prefer loading contents of .env file, if present, to process.env before the check is done.

Added dotenv@4.0.0 as a dependency
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kasrakhosravi
Copy link

👍

@Timer
Copy link
Contributor

Timer commented Jan 9, 2018

I think it's unexpected that a package looks at your .env files and populates process.env; this should be handled by your application if you're working in a non-CRA application.

Thanks!

@Timer Timer closed this Jan 9, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants