Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: When to use public folder #3606

Closed
wants to merge 1 commit into from
Closed

Update README.md: When to use public folder #3606

wants to merge 1 commit into from

Conversation

rwieruch
Copy link

I ran into this issue as well where I had to use a public folder to make larger (2mb) files (.json) available to my application via the public folder and a symlink to the files in the node_modules folder (how to, issues). Just added this use case to the list of "When to use a public folder" for others in case they run into it as well.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rwieruch
Copy link
Author

Never mind. It's not working this way (as shown in "how to") for .json files as well. They are still used by the build step and leads to JavaScript heap out of memory. Now I started to include the .json files in the index.html, but this isn't an elegant solution either, because I would have to load the json asynchronously in my JavaScript file afterward.

<script id="data" type="application/json" src="%PUBLIC_URL%/someData.json"></script>

Maybe there is anyway to get it into the script tags body, then it could be loaded synchronously in JavaScript?

@rwieruch rwieruch closed this Dec 16, 2017
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants