Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log message for service worker doc #3684

Closed
wants to merge 1 commit into from

Conversation

viankakrisna
Copy link
Contributor

@viankakrisna viankakrisna commented Jan 4, 2018

Motivation: #2398

Right now a lot of people is confused because they suddenly have service worker in production. Rather than letting people shoot their feet, i think we need to add this message to dev environment so they will know beforehand that there will be caching etc for PWA on production builds and can make the informed decision before running npm run build

screenshot of how it look in the console
screen shot 2018-01-04 at 12 37 44

@vpavlenko
Copy link

@viankakrisna Thanks, that's a great step towards lowering everyone's confusion with Service Workers. Wouldn't it be more helpful to add an info about it and the possibility to disable it right to the stub content, after "To get started, ..."?

@viankakrisna
Copy link
Contributor Author

@vpavlenko as there is current work to disable service-worker by default #3817, I think this PR is no longer necessary

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants