Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yarn and lerna monorepos. #3741

Merged
merged 29 commits into from
Feb 1, 2018

Commits on Jan 22, 2018

  1. Support for multiple source paths via package.json srcPaths entry.

    Initial support for yarn workspace.
    
    Support lerna workspace, fix for when to use template files.
    
    Remove support for specifying srcPaths in package.json.
    
    Re-enable transpilation caching.
    Brad Lemley authored and bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    bf2d814 View commit details
    Browse the repository at this point in the history
  2. Clean up, use file matching (similar to original) in webpack configs …

    …instead of matching function.
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    d9f5cf7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12e76ad View commit details
    Browse the repository at this point in the history
  4. Fix for eject.

    Note: monorepos won't work after eject.
    Can be fixed easily with JEST 22.0.?+ which has file pattern matches against realpaths.
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    bd1124d View commit details
    Browse the repository at this point in the history
  5. Filter tests to run only tests in monorepo components included by the…

    … app.
    
    (Not sure this is desireable, might be cool to be able to easily run all tests in monorepo from one app.)
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    eae24e9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f4b3a0d View commit details
    Browse the repository at this point in the history
  7. Fix eject.

    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    739b59b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7227e5d View commit details
    Browse the repository at this point in the history
  9. Include all cra-comp tests in monorepo instead of trying to include o…

    …nly tests that are dependencies of app.
    
    (tests can be easily filtered via jest cli if desired, e.g. 'npm test -- myapp comp1')
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    a93573d View commit details
    Browse the repository at this point in the history
  10. Pin find-pkg version.

    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    8102907 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9a1b92c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f4f2882 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d8e0319 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f96d04c View commit details
    Browse the repository at this point in the history
  15. Fix e2e test.

    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    565c1d7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    75ae0c5 View commit details
    Browse the repository at this point in the history
  17. Include individual package dirs as srcPaths instead of top-level mono…

    …repo root.
    
    Fixes build/start after eject.
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    fbc6bde View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    21f0b00 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9feda8b View commit details
    Browse the repository at this point in the history
  20. Cleanup.

    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    8ab33c7 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d52e904 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    79ac815 View commit details
    Browse the repository at this point in the history
  23. Incorporate review comments.

    * Simply monorepo pkg finder
    * Only include monorepo pkgs if app itself is included in monorepo
    * Check for specific tests in e2e
    bradfordlemley committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    3e81144 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Fixes for windows.

    bradfordlemley committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    ec6f5a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    978674f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc9b890 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Configuration menu
    Copy the full SHA
    4d0bc68 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Incorporate more review comments:

    * remove support for lerna w/o yarn workspace
    * add react and react-dom as devDeps to comp1 and comp2
    bradfordlemley committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    9e7490c View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Configuration menu
    Copy the full SHA
    50b4666 View commit details
    Browse the repository at this point in the history