Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump detect-port-alt #3787

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Bump detect-port-alt #3787

merged 2 commits into from
Jan 14, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 14, 2018

This should include some error handling that would work around #3690.

I haven't verified it works yet, but the last time I tried to do similar edits locally, and then inserted a throw in the same place the error was reported, detect-port said the ports were taken and jumped to a high port. I'm not sure why it didn't give me an error instead but this seems edge casey enough that I don't care strongly how it works as long as it doesn't crash.

@Timer Timer self-requested a review January 14, 2018 15:04
@gaearon gaearon merged commit 1e9eaf3 into master Jan 14, 2018
@Timer Timer deleted the gaearon-patch-1 branch January 14, 2018 15:12
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* Bump detect-port-alt

* Bump again
@powerangelito
Copy link

my problem was similar, install firebase and when executing npm start, this error came out

react-scripts start

I had to reinstall the dependencies with

npm install
then
npm i npm

I went back to execute npm start and solved the problem

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants