Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated react-scripts Readme.md to better document GitHub Pages #3821

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

EdwaRen
Copy link
Contributor

@EdwaRen EdwaRen commented Jan 17, 2018

Improved documentation in packages/react-scripts/template/README.md to clarify instructions for hosting React-app on GitHub Pages while connected to a custom domain name.

@gaearon gaearon added this to the 2.0.0 milestone Jan 17, 2018
@gaearon gaearon merged commit 0ddc043 into facebook:next Jan 17, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

Thanks!

akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants