Add Netlify to deploy instructions #386
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Netlify now autodetects create-react-app projects and sets the right build command and folder settings automatically.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| Then add this import statement to `src/index.js`: | ||
|
|
||
| ```js | ||
| import "file?name=_redirects!./_redirects"; |
There was a problem hiding this comment.
I don’t think we want to expose a webpack-ism like this to the user.
We should have a way to add arbitrary files to the build, I think.
There was a problem hiding this comment.
Yea.. I mean to take a look at this soon. The only problem I see so far is that it won’t allow adding anything to the root folder which seems like a common use case.
There was a problem hiding this comment.
Well we could easily copy everything EXCEPT the files that are there by default and the src/ folder?
There was a problem hiding this comment.
I’m not sure if we should do that although it might be reasonable.
There was a problem hiding this comment.
Maybe the “root files” use case is just not important, and we can tell people to add their own cp post-build command.
There was a problem hiding this comment.
Having to add a custom post build command just to include a robots.txt or a .htaccess or a _redirects or any similar file that needs to go in the root seems a bit complicated.
I think having anything in the static folder copied into the build root is the best option. Hugo (the static site generator) works like that and I don't see that creating confusion...
There was a problem hiding this comment.
The only reason I see that confusing is because if you want to put something into js for whatever reason, you have to create /static/static/js/ which is funny.
There was a problem hiding this comment.
I would argue for not having the static folder end up in build/static but copying anything in static to build in regards to #226 - so you would have static/robots.txt or static/js/modernizr.js or the like.
There was a problem hiding this comment.
Looks like it'll take a bit to figure out the best way to add static files to the root folder, so I dropped the specific instructions and left it up to the end user to get the _redirects file into the build folder.
|
Sorry I didn’t come back to this timely. Can you please put Netlify before Now and I’ll merge? |
ghost
added
the
|
Thanks again for the PR. |
This ads instructions for both manual and automated deploys to Netlify as well as instructions for history pushstate support.