Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipackage monorepo base configuration #405

Closed
wants to merge 8 commits into from

Conversation

ryanyogan
Copy link

@ryanyogan ryanyogan commented Aug 8, 2016

Monorepo basic configuration in reference to #403

Changes made to directory structure

|- packages (new root directory)
|-- create-react-app (was parent directory)
|-- react-scripts (was global-cli)

Testing

To test as you would use npm i create-react-app -g
cd packages/create-react-app && npm i . -g to install locally or npm link
create-react-app my-app should work as before

To test the build process
cd packages/react-scripts && npm i && npm run build

Notes

This is just the directory structure changes, perhaps a little discussion around @hzoo's comment regarding Lerna Independant is warranted?

# or global?
npm install lerna --save-dev
./node_modules/.bin/lerna init (add lerna.json)
./node_modules/.bin/lerna bootstrap (npm installs packages, links)
# when publish is necessary
./node_modules/.bin/lerna publish --independent

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ryanyogan
Copy link
Author

I'll fix that travis explosion

@ghost ghost added the CLA Signed label Aug 8, 2016
@ghost
Copy link

ghost commented Aug 8, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ryanyogan
Copy link
Author

@gaearon I'm having a little trouble with the e2e, did I mess something up something obvious I am missing?

@ghost ghost added the CLA Signed label Aug 8, 2016
@@ -34,11 +34,11 @@ function resolveApp(relativePath) {
if (isInCreateReactAppSource) {
// create-react-app development: we're in ./config/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change this comment: we’re in ./packages/react-scripts/config

@gaearon
Copy link
Contributor

gaearon commented Aug 8, 2016

Try running sh tasks/e2e.sh locally and see why React doesn’t end up in node_modules?

@ryanyogan ryanyogan closed this Aug 10, 2016
@ryanyogan ryanyogan deleted the monorepo branch August 10, 2016 21:18
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants