remove variations in Button example code #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| @@ -228,9 +228,11 @@ import './Button.css'; // Tell Webpack that Button.js uses these styles | |||
| class Button extends Component { | |||
| render() { | |||
| // You can use them as regular CSS styles | |||
| return <div className="Button" />; | |||
There was a problem hiding this comment.
It’s not correct: in the new code, Button renders to Button which will cause infinite recursion.
What you probably want to change is to make the first example return <div className="Button" /> instead of vague // ....
|
Closing per comment—the change is incorrect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change that may help flatten some people's learning curve: button example code was different from the first instance to a subsequent instance. Similarly, the final example did not include the 'export' statement (which, as is pointed out earlier in the README, creates an issue that can be hard to troubleshoot). This small change proposes fixes to these two items to avoid possible confusion.