Try using bundledDependencies

[gaearon]

Alternative approach to shrinkwrap, as suggested in #14 (comment) and ionic-team/ionic-cli#636.

[gaearon]

Numbers on my machine:

type	npm2 (cold)	npm2 (warm)	npm3 (cold)	npm3 (warm)
no bundle	386s	113s	113s	93s
bundle	63s	41s	96s	77s

Bundled deps win in all cases, sometimes significantly (cold npm@2).
I’m going to err on the side of getting it in.

If we have any issues we’ll revert this.

[just-boris]

Hello! I have checked bundledDependencies thing again and got quite different results:

React-scripts@0.6.1 installation time

node@v6.7.0 + npm@3.10.3: 99s (99s warm)
node@v4.6.0 + npm@2.15.9: 51s (40s warm)

Then I created a fork, @just-boris/react-scripts, with only one change - no bundled deps, and checked its installation time

node@v6.7.0 + npm@3.10.3: 78s (36s warm)
node@v4.6.0 + npm@2.15.9: 132s (110s warm)

The installation with npm2 is faster with bundled deps, but not for npm3.
Maybe something was changed for the last 3 months, but now bundledDependencies slow down the installation on npm3 for sure

How to reproduce

I have used official node.js docker images for node6+npm3 and node4+npm2. Every command was run 3 times on clean image (no cache).

The command was the following:

time npm install react-scripts --quiet

I have a fork of react-scrips@0.6.1 with removed bundled dependencies. You can find it there. The installation command is the same:

time npm install @just-boris/react-scripts --quiet

Warm time: to find out warm time I installed package one time to fill cache with data, then removed local node_modules folder and run install command again:

time npm install react-scripts --quiet --cache-min=999999

Note that I used cache-min flag to force using the cache as much as possible.

[gaearon]

The main point was to speed up cold on npm 2 because that's going to be first people's experience with CRA for the currently stable Node version.

[just-boris]

Good point but now it seems unfair, when people who want to use the latest version have to suffer, because of some people who still use the previous version and there some tricks for them.

[gaearon]

We plan to drop npm 2 support in the future. When we do so, we can re-evaluate this choice.

[marvinhagemeister]

Node 6 will be released as the next LTS on October 18 if everything goes to plan. It ships with npm3 by default, so it seems reasonable to focus more on performance with npm3.

[gaearon]

Oh, that's awesome. We'll be happy to switch rightafter that.

[kitze]

@gaearon will that 👆 fix this 👉 kitze#13 ? As explained here it's a problem with bundledDependencies.

[just-boris]

Hot off the press: tested with yarn.

react-scripts: 30s
my fork without bundledDependencies: 28s

These numbers are so small, so now I don't actually care about bundledDependencies tradeoffs, I am going to just use Yarn.