Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scss #412

Closed
wants to merge 1 commit into from
Closed

support scss #412

wants to merge 1 commit into from

Conversation

komkanit
Copy link

@komkanit komkanit commented Aug 9, 2016

Can import .scss instead of css.
My code only support scss not inculde sass

This is my first pull request in open source project, if some thing not correct you can recommend me.
Thank you.

@ghost
Copy link

ghost commented Aug 9, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

Hi, thanks for the PR! Sorry to disappoint you—we discussed this in #351, and we don’t currently want to enable SCSS (or other CSS preprocessors) in the default setup.

@gaearon gaearon closed this Aug 9, 2016
@devmetal
Copy link

@gaearon @komcal
Hi, i also like to use scss. What do you think about a command line switch? Like in expressjs generator.

@gaearon
Copy link
Contributor

gaearon commented Sep 24, 2016

Hi @devmetal! Please see an extensive discussion about this in #78 and other threads.

@rickharrison
Copy link

For those looking for sass support, check out https://github.com/rickharrison/create-react-app-sass

@komkanit
Copy link
Author

@rickharrison Thank!

@felquis
Copy link

felquis commented Oct 26, 2016

I think the most basic way to do it is to run npm run eject and edit the dev and prod files, I did it in this repository https://github.com/felquis/react-try-out/ adding css modules and sass to use react-toolbox.

@ezhlobo
Copy link

ezhlobo commented Oct 26, 2016

Hi guys! Please take a look at ezhlobo/react-scripts, I added the possiblity to extend webpack's configs. I use react-scripts in some projects where we have different configs and my fork with two lines changed is convenient for doing it.

//CC @komcal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants