Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve quotes in font values during minification #4122

Closed
wants to merge 1 commit into from
Closed

Preserve quotes in font values during minification #4122

wants to merge 1 commit into from

Conversation

veltman
Copy link

@veltman veltman commented Mar 7, 2018

Closes #4121.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 2.0.0 milestone Mar 8, 2018
@Timer
Copy link
Contributor

Timer commented Mar 8, 2018

@veltman just letting you know I'm going to sit on this for a while before merging as we figure out a final patch release for 1.x.

@iansu
Copy link
Contributor

iansu commented Mar 8, 2018

Should we update this PR to target master instead of next then?

@Timer Timer closed this Sep 26, 2018
@Timer Timer reopened this Sep 26, 2018
@Timer Timer modified the milestones: 2.0.x, 2.x Sep 26, 2018
@gaearon gaearon closed this Nov 1, 2018
@Timer Timer changed the base branch from next to master January 8, 2019 00:38
@Timer Timer modified the milestones: 2.x, 2.1.x Jan 8, 2019
@Timer Timer reopened this Jan 8, 2019
@Timer Timer modified the milestones: 2.1.x, 2.1.4 Jan 8, 2019
@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
@iansu iansu modified the milestones: 2.1.6, 2.1.x, 3.x Mar 6, 2019
@heyimalex
Copy link
Contributor

Should be closed by #8106?

@heyimalex heyimalex closed this Dec 13, 2019
@lock lock bot locked and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmourao pmourao pmourao approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

Prod config produces invalid font-family values in minified CSS
8 participants
@veltman @facebook-github-bot @Timer @iansu @heyimalex @pmourao @gaearon @ianschmitz