Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ModuleScopePlugin accecpts an array as its appSrc #4138

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

froyog
Copy link
Contributor

@froyog froyog commented Mar 10, 2018

When ejected, you can now pass in an array as the appSrc for ModuleScopPlugin.
Implement of #4079

test plan:

  1. yarn create-react-app test-app
  2. cd test-app
  3. yarn run eject
  4. mkdir docs
  5. In config/paths.js, add docsSrc: resolveApp('docs')
  6. In config/webpack.config.dev.js, modify new ModuleScopePlugin(paths.appSrc, [paths.appPackageJson]), to new ModuleScopePlugin([paths.appSrc, paths.docsSrc], [paths.appPackageJson]),
  7. yarn start. You should be able to import stuff from both src/ and docs/.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -57,7 +57,7 @@ module.exports = {
```


#### `new ModuleScopePlugin(appSrc: string, allowedFiles?: string[])`
#### `new ModuleScopePlugin(appSrc: string | string[], allowedFiles?: string[])`

This Webpack plugin ensures that relative imports from app's source directory don't reach outside of it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "source directories"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably right. Thanks.

@andriijas andriijas added this to the 2.0.0 milestone Mar 20, 2018
@andriijas andriijas merged commit 1922f4d into facebook:next Mar 23, 2018
tvalentius added a commit to tvalentius/create-react-app that referenced this pull request Mar 23, 2018
Allow ModuleScopePlugin accecpts an array as its appSrc (facebook#4138)
@iansu iansu mentioned this pull request Mar 25, 2018
23 tasks
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants