Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the best tagline I can think of #414

Closed
wants to merge 1 commit into from

Conversation

ryanflorence
Copy link

No description provided.

@ghost
Copy link

ghost commented Aug 9, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@eliperelman
Copy link
Contributor

@ryanflorence 😄. Or even:

Saving the world from JS fatigue, one React app at a time.

@ryanflorence
Copy link
Author

I see no puns in your tagline. I still vote for mine. I like your avatar though.

@eliperelman
Copy link
Contributor

@ryanflorence yeah, no puns, more tongue-in-cheek (and thanks!)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@eliperelman
Copy link
Contributor

@facebook-github-bot honestly, I don't think that tagline is much better. What kind of bot are you?!

@ghost ghost added the CLA Signed label Aug 9, 2016
@ryanflorence
Copy link
Author

@facebook-github-bot You're welcome.

@hnordt
Copy link
Contributor

hnordt commented Aug 9, 2016

I liked the tagline, but in my opinion it shouldn't merged, looks amateur.

@ghost ghost added the CLA Signed label Aug 9, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

Love this but let's keep it an unofficial tagline. 😉

@gaearon gaearon closed this Aug 9, 2016
@ryanflorence
Copy link
Author

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

I can empathize with the sentiment but I also feel it’s a bit dismissive to all the tools that we build upon. After all we just put them in a nice package but they do all the heavy lifting!

@ryanflorence
Copy link
Author

I love how sincere you are. I'm just messing around, I wouldn't want it merged either.

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

I know but still worth saying it.

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

Also hope to see more PRs from you!

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants