Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to CI #4193

Merged
merged 1 commit into from
Mar 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-error-overlay/src/effects/proxyConsole.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const registerReactStack = () => {
// $FlowFixMe
console.reactStack = frames => reactFrameStack.push(frames);
// $FlowFixMe
console.reactStackEnd = frames => reactFrameStack.pop();
console.reactStackEnd = () => reactFrameStack.pop();
}
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-error-overlay/src/utils/getStackFrames.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { unmap } from './unmapper';

function getStackFrames(
error: Error,
unhandledRejection: boolean = false,
unhandledRejection: boolean = false, // eslint-disable-line
contextSize: number = 3
): Promise<StackFrame[] | null> {
const parsedFrames = parse(error);
Expand Down
1 change: 0 additions & 1 deletion tasks/e2e-installs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ root_path=$PWD
if hash npm 2>/dev/null
then
npm i -g npm@latest
npm cache clean || npm cache verify
fi

# Bootstrap monorepo
Expand Down
1 change: 0 additions & 1 deletion tasks/e2e-kitchensink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ root_path=$PWD
if hash npm 2>/dev/null
then
npm i -g npm@latest
npm cache clean || npm cache verify
fi

# Bootstrap monorepo
Expand Down
1 change: 0 additions & 1 deletion tasks/e2e-monorepos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ root_path=$PWD
if hash npm 2>/dev/null
then
npm i -g npm@latest
npm cache clean || npm cache verify
fi

# Bootstrap create-react-app monorepo
Expand Down
1 change: 0 additions & 1 deletion tasks/e2e-simple.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ fi
if hash npm 2>/dev/null
then
npm i -g npm@latest
npm cache clean || npm cache verify
fi

# Bootstrap monorepo
Expand Down